Fix KeyError
when creating a new secret
#2793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce the issue:
The exception raises because create secrets API
/secrets/create
onlyreturn the
id
attribute:https://docs.docker.com/engine/api/v1.41/#operation/SecretCreate
The secret model is created using just the
id
attribute and failswhen looking for Spec.Name attribute.
I came up with a ugly solution but will prevent the problem to happen
again:
After the API call, I added the name attribute to the right place to be
used on the property name.
It isn't the most elegant solution, but it will do the trick.
I had a previous PR #2517 when I propose using the
id
attributeinstead of
name
on the__repr__
method, but I think this one will be better.That fixes #2025
EDIT: It will save a new request to get the name.