Draft: Fix pywin32 dep, widen range to >=227,<400

[jmahlik]

1. I'm not sure what the testing process is supposed to look like for windows. Is there ci in place for it? Did the best I could.
   • Ran the test suite on python==3.9.0,&python==3.7.0 pywin32==301, dockerengine==20.10.7 via docker desktop w/ wsl backend using py.test ./tests/
   • 2 below failed, they seem related to not using the makefile to test (the makefile runs everything on linux containers so that didn't seem right)
   • Ran py37 via tox, should more python interpreters/version combos of pywin32 be added here maybe? Seems like a troublesome dependency that could benefit from combinations. Maybe a separate testenv for it that only triggers for windows platforms?
   • Flake8 was failing, I can fix it if desired, trying not to touch a bunch of files.
2. Is widening the range acceptable? pywin32 seems to stick to major version bumps for breaking changes changelog. There's a bunch of issues related to pywin32 versions, about half seem related to version pinning/various versions of python.

Failures

tests\unit\utils_config_test.py:27: in test_find_config_fallback
tests\unit\utils_test.py:141: in test_kwargs_from_env_no_cert_path

closes #2835

[jmahlik]

Added a possible tox config that will test this across all supported pythons and a range of pywin32's depending on platform. This should give confidence as to what pywin32's can be supported based on python version.

It does take a while to run initially because there are many venvs. Using tox -p all -r causes 100% cpu usage/probable race condition on my machine, so use tox -r only.

Thinking it would be best to run the integration tests in the windows env as well?

[chickenkiller]

hello, I would really appreciate that this dependency could be bumped up! It is blocking usage of docker-py on environments such as MSYS2... Thanks in advance

[jmahlik]

hello, I would really appreciate that this dependency could be bumped up! It is blocking usage of docker-py on environments such as MSYS2... Thanks in advance

It's seems like quite a rough dep to test. The unit tests did pass for all the version combos besides for a test involving tls (digging in to that more).

I haven't had a chance to run the integrations against all combos of python/pywin32 yet. It's almost as if one needs to run it in cmd and msys2.

[tadeu]

Gentle ping on this :)

[jmahlik]

Gentle ping on this :)

If some folks would like to clone and try to debug the tls issues, I could use some help in validating which versions are compatible. It takes a long time to run against all these versions on my machine.

There are failing integration tests on windows in the current test suite with the current deps on python 3.8, so trying to debug through those as well. Some might be docker/env related.

[stan-sz]

Related to #2903

[jackwhelpton]

Any progress on this? If there's anything I can do to help out let me know: new to this codebase though.

[milas]

Hi! Thanks so much for your PR and apologies for the delay in review. A fix for this has been merged and we're planning to issue a new release containing it soon. For context, changes similar to yours were done in #3004 to address some CI changes in the repo, which blocked merging of your PR as-is, and given the delay on this, we wanted to be respectful of our contributor's time and not require you to rebase + re-review.