Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swarm support for DataPathPort #2987

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

dexteradeus
Copy link
Contributor

@dexteradeus dexteradeus commented May 11, 2022

Adds support for DataPathPort in much the same way as DataPathAddr when initializing a swarm.

This option is supported as of api version 1.40:
https://docs.docker.com/engine/api/v1.40/#operation/SwarmInit

@dexteradeus dexteradeus force-pushed the data_path_port branch 2 times, most recently from fc1a4da to 0e00980 Compare May 11, 2022 21:01
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

The changes look good, I'm happy to get this merged if you amend your commit to include a DCO sign-off

@milas milas added the dco/no label Aug 12, 2022
- Adds support for setting the UDP port used for VXLAN traffic between
  swarm nodes

Signed-off-by: Chris Hand <dexteradeus@users.noreply.github.com>
@dexteradeus
Copy link
Contributor Author

Commit amended. Sorry about that.

@milas milas enabled auto-merge (squash) August 12, 2022 13:58
@milas milas merged commit fc86ab0 into docker:main Aug 12, 2022
@milas
Copy link
Contributor

milas commented Aug 12, 2022

Not a problem at all - merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants