Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add flake8 job #3009

Merged
merged 2 commits into from
Jul 26, 2022
Merged

ci: add flake8 job #3009

merged 2 commits into from
Jul 26, 2022

Conversation

milas
Copy link
Contributor

@milas milas commented Jul 26, 2022

Project is already configured for flake8 but it never gets run in
CI.

(Since flake8 wasn't actually being run in CI, we'd accumulated some
violations, which are fixed here.)

milas added 2 commits July 26, 2022 13:48
Project is already configured for flake8 but it never gets run in
CI.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Since flake8 wasn't actually being run in CI, we'd accumulated some
violations.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas requested a review from a team July 26, 2022 17:50
@milas milas self-assigned this Jul 26, 2022
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milas milas merged commit b9ca58a into docker:master Jul 26, 2022
@milas milas deleted the lint-flake8 branch July 26, 2022 19:48
@milas milas added this to the 6.0.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants