Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run SSH integration tests #3012

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

milas
Copy link
Contributor

@milas milas commented Jul 27, 2022

Fix & enable SSH integration test suite.

This also adds a new test for connecting to unknown hosts when
using the Python SSH implementation (Paramiko). See #2932 for
more info.

Because of the above, some of the config/static key files have been
moved around and adjusted.

@milas milas requested a review from a team July 27, 2022 18:48
@milas milas self-assigned this Jul 27, 2022
Fix & enable SSH integration test suite.

This also adds a new test for connecting to unknown hosts when
using the Python SSH implementation (Paramiko). See docker#2932 for
more info.

Because of the above, some of the config/static key files have been
moved around and adjusted.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas force-pushed the integration-tests-ssh branch from 08bcf6b to 71a97ba Compare July 27, 2022 19:03
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good? A lot of duct tape, but if it gets more tests working, 👍

@milas
Copy link
Contributor Author

milas commented Jul 27, 2022

It's not QUITE as bad as it seems - I moved some files around in the process to make it easier to tell what's client vs server and tried to eliminate some duplicates (e.g. known_hosts is constructed from the client pubkey file so we don't need to maintain 2x copies), which made it look a bit more involved than it really is 😓

@milas milas merged commit acdafbc into docker:master Jul 27, 2022
@milas milas deleted the integration-tests-ssh branch July 27, 2022 20:25
@milas milas added this to the 6.0.0 milestone Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants