Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simple support for propagation in bind mounts #3164

Closed
wants to merge 17 commits into from

Conversation

jannefleischer
Copy link
Contributor

@jannefleischer jannefleischer commented Aug 10, 2023

For autofs-support in Jupyterhub I needed propagation support in bind mounts. So I added this.

Though I don't know if you want it in here, due to the lack of Docker Desktop support.

akx added 12 commits June 6, 2023 17:24
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, spoke too soon. The flake8 lint job is failing. If you fix the issues there, I'll get this merged

milas and others added 2 commits August 14, 2023 15:39
@jannefleischer jannefleischer requested a review from milas August 15, 2023 07:09
milas added a commit that referenced this pull request Aug 15, 2023
Manually merging #3164.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas
Copy link
Contributor

milas commented Aug 15, 2023

Thanks for the PR and fixes - this is merged via 0f0b20a.

(Apologies for any noise/confusion, I had to rebase and do some Git shenanigans 😓)

@milas milas closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants