-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added simple support for propagation in bind mounts #3164
Conversation
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, spoke too soon. The flake8 lint job is failing. If you fix the issues there, I'll get this merged
Signed-off-by: Janne Jakob Fleischer <janne.fleischer@ils-forschung.de>
Manually merging docker#3126.
Manually merging #3164. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Thanks for the PR and fixes - this is merged via 0f0b20a. (Apologies for any noise/confusion, I had to rebase and do some Git shenanigans 😓) |
For autofs-support in Jupyterhub I needed propagation support in bind mounts. So I added this.
Though I don't know if you want it in here, due to the lack of Docker Desktop support.