Bump default API version to 1.43 (Moby 24.0) #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
thaJeztah
reviewed
Dec 19, 2023
| @@ -1,7 +1,7 @@ | |||
| import sys | |||
| from .version import __version__ | |||
|
|
|||
| DEFAULT_DOCKER_API_VERSION = '1.41' | |||
| DEFAULT_DOCKER_API_VERSION = '1.43' | |||
| MINIMUM_DOCKER_API_VERSION = '1.21' | |||
There was a problem hiding this comment.
We should also start looking at raising this minimum, but I don't know if there's code specific in docker-py that handles differences between versions @milas ?
We're starting to deprecate old API versions, and the initial step is to disable (by default) API versions < 1.24. API 1.24 is the last version of the API before introduction of API version negotiation, so that's the version the CLI falls back to if it's unable to negotiate.
- daemon: raise default minimum API version to v1.24 moby/moby#46887
⚠️ there's still some debate on the client-side of that though; client: deprecate old API versions moby/moby#46962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update API version to the latest maintained release.