Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview.md #1007

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Update overview.md #1007

merged 1 commit into from
Jan 18, 2017

Conversation

NickvdMeij
Copy link
Contributor

Proposed changes

Update overview.md to reference possible issues regarding windows to unix path convert issues

Related issues (optional)

Reference for docker github repo: link

Update overview.md to reference possible issues regarding windows to unix path convert issues
@joaofnfernandes
Copy link
Contributor

Thanks for contributing 🐳
I understand that you're trying to include information so that Windows users don't get caught by surprise with the differences in environment variables, but I don't think we should do that in the Overview article. That article should explain what is Compose and why you should care. It should not go into nitty-gritty details, that can confuse new users.

Maybe what we need is a separate article explaining all the caveats of running Compose on Windows. @londoncalling what do you think?

@londoncalling
Copy link
Contributor

Thanks @joaofnfernandes .

@NickvdMeij I'll either merge this or find a better way of incorporating it. I looked at the link you provided, and see it definitely needs to be addressed. I'm working on Compose docs today, so I'll look at this as a part of that work. Thanks! More soon.

@londoncalling
Copy link
Contributor

@NickvdMeij @thaJeztah @joaofnfernandes given the background on this per the discussion thread in this Compose issue, I'm merging this. Will make a couple of minor corrections and look to see if there is elsewhere we can add it as well. Sorry you had to spend 10 hours on this @NickvdMeij . Thanks for contributing to save someone else that struggle.

@londoncalling londoncalling merged commit ec839d5 into docker:master Jan 18, 2017
@londoncalling londoncalling mentioned this pull request Jan 18, 2017
@NickvdMeij
Copy link
Contributor Author

@londoncalling No problem, I love docker and I dont mind giving feedback and enhancing the documentation ;-) that's the power of open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants