-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: rework ci/gha docs #15898
build: rework ci/gha docs #15898
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5ccd41b
to
f62b12a
Compare
6f44472
to
f1b055d
Compare
@crazy-max do you know why the gha advanced example pages do not get any breadcrumbs?? |
Hum I don't know, maybe there is a limit to the number of items? Any idea @thaJeztah? Edit: yes looks limited to 4 levels: docs/_includes/breadcrumbs.html Lines 100 to 103 in 5636c5d
Should be dynamic imo. |
5284ebc
to
b408cbf
Compare
b408cbf
to
e858fff
Compare
e858fff
to
bc927ff
Compare
bc927ff
to
04acf53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feeling about the examples layout. On one hand there are too many pages and TOC order is not quite satisfying. I wonder if this could just be on a single examples.md
or cookbook.md
page? WDYT?
87816ac
to
4ec213f
Compare
I agree and I've updated the structure now! ptal and let me know if there's anything else you'd like me to change :) Also wouldn't hurt if you just glanced over the "template repo" that I created for the tutorial. Before my changes, we asked ppl to fork an existing repo that used nginx and static HTML. I created a slimmer version that is also a template repo: https://github.com/dvdksn/clockbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wouldn't hurt if you just glanced over the "template repo" that I created for the tutorial. Before my changes, we asked ppl to fork an existing repo that used nginx and static HTML. I created a slimmer version that is also a template repo: https://github.com/dvdksn/clockbox
Yes your example looks good to me!
I agree and I've updated the structure now! ptal and let me know if there's anything else you'd like me to change :)
Some examples are more important than others. I think we should change the order and group some of them:
- Push to multi-registries
- Manage tags and labels
- Multi-platform images
- Cache
- Secrets
- Export image to Docker
- Test your image before pushing it
- Local registry
- Share built image between jobs
- Named contexts
- Builder configuration
- Append additional nodes
- Authentication for remote builders
- BuildKit daemon configuration
- Standalone mode
- Isolated builders
- Copy images between registries
- Update Docker Hub repository description
For Registry mirror
we should cross link to https://deploy-preview-15898--docsdocker.netlify.app/build/buildkit/configure/#registry-mirror
Signed-off-by: David Karlsson <david.karlsson@docker.com>
4ec213f
to
f636cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This PR brings a restructuring of GitHub actions documentation, and expands on the existing docs by: