Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bake: remote auth variables #19749

Merged
merged 1 commit into from
Apr 18, 2024
Merged

bake: remote auth variables #19749

merged 1 commit into from
Apr 18, 2024

Conversation

dvdksn
Copy link
Collaborator

@dvdksn dvdksn commented Apr 8, 2024

Description

Adds new variables for preflight auth when using remote bake definitions in private repos

https://deploy-preview-19749--docsdocker.netlify.app/build/building/variables/#buildx_bake_git_auth_header

Related issues or tickets

docker/buildx#2363

Reviews

  • Technical review
  • Editorial review

@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit b0847cd
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/661f978d52e29e00083c4eef
😎 Deploy Preview https://deploy-preview-19749--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn added this to the buildx v0.14.0 milestone Apr 8, 2024
@dvdksn dvdksn added the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Apr 8, 2024
@dvdksn dvdksn marked this pull request as ready for review April 8, 2024 08:45
@dvdksn dvdksn requested a review from crazy-max as a code owner April 8, 2024 08:45
@dvdksn dvdksn requested a review from a team April 8, 2024 08:45
crazy-max
crazy-max previously approved these changes Apr 8, 2024
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was also wondering if we should put the supported buildx version for our variables?

@dvdksn
Copy link
Collaborator Author

dvdksn commented Apr 8, 2024

ah yes good point.

craig-osterhout
craig-osterhout previously approved these changes Apr 8, 2024
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crazy-max
crazy-max previously approved these changes Apr 8, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@crazy-max crazy-max removed the status/do-not-merge Pull requests that are awaiting some event or decision before they can be merged. label Apr 18, 2024
@dvdksn dvdksn merged commit 3072fd0 into docker:main Apr 18, 2024
9 checks passed
@dvdksn dvdksn deleted the bake-auth-remote-def branch April 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants