Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid gh api rate limit for cache backends #20238

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jun 14, 2024

Description

New repository and ghtoken parameter for gha cache backend that allows people to avoid default rate limits in gha by making authenticated requests

Related issues or tickets

moby/buildkit#4788

@dvdksn dvdksn requested a review from crazy-max as a code owner June 14, 2024 08:56
@github-actions github-actions bot added the area/build Relates to Dockerfiles or docker build command label Jun 14, 2024
Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 398de77
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/666c1bbe619dfe0008a85912
😎 Deploy Preview https://deploy-preview-20238--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn
Copy link
Contributor Author

dvdksn commented Jun 14, 2024

@crazy-max a lot of guessing on how this works on my end here. Please check it carefully

@dvdksn dvdksn force-pushed the build-gha-check-keys branch from 716acb4 to 087249d Compare June 14, 2024 09:54
@dvdksn dvdksn requested a review from crazy-max June 14, 2024 09:55
@dvdksn dvdksn force-pushed the build-gha-check-keys branch from 087249d to fcbb42f Compare June 14, 2024 10:08
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the build-gha-check-keys branch from fcbb42f to 398de77 Compare June 14, 2024 10:30
@dvdksn dvdksn requested a review from crazy-max June 14, 2024 10:30
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks @dvdksn!

@dvdksn dvdksn merged commit 1ebeae3 into docker:main Jun 14, 2024
11 checks passed
@dvdksn dvdksn deleted the build-gha-check-keys branch June 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants