-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a language specific guide for Bun #20936
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d6bc8e4
to
7fee82a
Compare
5004525
to
e4246ad
Compare
Ready for review (Apologies for above mess) Wow, there was a lot of conflict and logical change. I think docs have changed how it resolves the path plus folder structure. |
Thanks for the review, @dvdksn. Updated the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like tests are failing, could you check your links?
Also, I would like us to add a bit more detail to this guide. Other than the sample project, it doesn't contain any information or examples specific to Docker+Bun. Is there something more we can say about developing with Docker and Bun that might be useful to add here? For example, if there are differences between how the official node
image and the oven/bun
work, or if there's anything to keep in mind w.r.t. cache mounts, etc.
Hey, @dvdksn, The links are fine I double-checked. Could you point out which link is creating the issue? Also, I checked the error in Workflow it seems something different
I was thinking of adding more content to this guide in another PR and was thinking of this one to go live and iterate over it. But, I will add more details to this PR itself. Thnak you. |
Thanks @Pradumnasaraf. Let's add the details to this PR. |
The actual error is a bit obstructed in the logs;
|
Hey, #22 2.371 ERROR [en] REF_NOT_FOUND: Ref "/manuals/compose/file-watch.md" from page "/guides/language/bun/develop": page not found I checked the page is there and the same link is added to other guides as well. I am not sure why it's giving an error. It's working fine as well when running locally. Plus, I have updated the guide, let me know if you have any more feedback. Thanks! |
2b92340
to
6997590
Compare
Hey, @dvdksn Can you please have a look as the file/folder structure again changed and makes it hard to resolve merge conflicts? |
@Pradumnasaraf yep, taking a look |
Thank you. I think this commit push, will sort out the build issue thing. EDIT: It didn't |
115111b
to
49f1b81
Compare
I think everything looks fine and good to merge. Thank you for the fixes @dvdksn. |
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
49f1b81
to
29fc291
Compare
Pushed a minor editorial/refactoring on the bun intro prose, and a few other nits. Let's get this in! Thanks @Pradumnasaraf |
Thank you, David. I think it will take some time to show up on the docs page! |
@Pradumnasaraf I just kicked the publishing workflow, so the guide should be available in a few minutes from now 👍🏻 |
Description
Add language specfic guide for Bun
Related issues or tickets
Closes #20796
Reviews