Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container supported development learning path #20958

Merged

Conversation

mikesir87
Copy link
Member

Description

Creation of a new learning path focused on container-supported development.

The videos are still being edited and uploaded, hence the reason this is starting as a draft. However, the text content can be reviewed and approved while we wait for the videos.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added hugo Updates related to hugo area/guides labels Sep 20, 2024
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 49d6412
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/670d053d9c29ea0008d591b4
😎 Deploy Preview https://deploy-preview-20958--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikesir87 mikesir87 marked this pull request as draft September 20, 2024 21:10
@dvdksn dvdksn requested a review from a team September 25, 2024 16:05
@mikesir87 mikesir87 force-pushed the container-supported-development-learning-path branch from 37504be to 3dbef3e Compare October 9, 2024 15:55
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open questions/thoughts

With the new layout, where the modules are pages as opposed to accordions, I get the feeling that something is missing. Compare them to the concepts, where the videos were accompanied by "explanation" and "try it out" sections.

I wonder if we should try and add similar content to the modules in this guide, to make it more complete? I realize this is a tall order. But I feel like it would help give the guide more substance.

The WireMock and pre-seeding databases guides seem like they're quite similar to the "runnig databases locally" and "mocking API endpoints" modules in this series. I wonder if we should try and consolidate?

content/guides/container-supported-development/_index.md Outdated Show resolved Hide resolved
content/guides/container-supported-development/_index.md Outdated Show resolved Hide resolved
@dvdksn dvdksn requested a review from craig-osterhout October 9, 2024 16:29
mikesir87 and others added 2 commits October 9, 2024 12:33
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@mikesir87
Copy link
Member Author

@dvdksn Good question about the content with the shift.

The idea was that this guide would serve as a starting point to think about using containers for development, helping be a response when someone asks "Why should I use containers in local development if my app runtime isn't containerized?". With that, the thought was to have these introduce the concept and do various demos, but then point to the actual use case guide to learn how to do it yourself (intro vs how-to). Once those are merged, I was going to add links to the pages to point to those guides to make it easier to follow the journey.

Does that make sense? I'm open to ideas/feedback too!

@dvdksn
Copy link
Collaborator

dvdksn commented Oct 9, 2024

@mikesir87 thanks, yes that makes sense.

I wonder if the multi-page format is appropriate here, or if we should try and consolidate it to a single page. Given that there isn't very much text content here. Do you have a preference?

Sorry about the bikeshedding 😅 Still figuring out the information architecture with these new content types we now have.

@mikesir87
Copy link
Member Author

@dvdksn I'm open to ideas and trying out different things. I split it to keep it similar to the other migrated learning paths. We can either add some more text to each of the videos or merge it all back together. Do you have a preference?

@dvdksn
Copy link
Collaborator

dvdksn commented Oct 9, 2024

I don't mean to block this guide, just to raise the observation. I'm fine with keeping it like it is for consistency's sake; we can put a pin in this for the future. If we decide to change the format we should do it across the board anyway.

@craig-osterhout
Copy link
Contributor

I have nothing to add that David hasn't. I have no comments on the content itself, but I get the same feeling when looking at the page. The page design feels empty with just a couple sentences and a video on a whole page.
The old layout that had a single page with the intro and multiple videos felt more substantial with the same content.
+1 to trying a different layout for the learning paths as a whole. Not a blocker to me.

Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikesir87 I think this looks better! A couple extreme nits but other than that LGTM. Let me know if it's ready to ship (pr is still in draft)

content/guides/container-supported-development.md Outdated Show resolved Hide resolved
content/guides/container-supported-development.md Outdated Show resolved Hide resolved
mikesir87 and others added 2 commits October 14, 2024 07:49
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@mikesir87 mikesir87 marked this pull request as ready for review October 14, 2024 11:50
@mikesir87
Copy link
Member Author

Good to go on my end! Removed the draft status @dvdksn 👍

@dvdksn dvdksn merged commit 0c95390 into docker:main Oct 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants