Skip to content
This repository has been archived by the owner on Jun 22, 2021. It is now read-only.

Add e2e test for building from private registry #16

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

zappy-shu
Copy link
Collaborator

Updates the e2e test for building from a private registry during build-push. First build and push a base image and remove it locally then build and push an image based on it.

@zappy-shu zappy-shu requested a review from justincormack March 20, 2020 13:52
@zappy-shu zappy-shu force-pushed the login-before-build branch from 6db5653 to cdab64c Compare March 20, 2020 14:14
@zappy-shu zappy-shu requested a review from mat007 March 20, 2020 14:29
@mat007 mat007 changed the title Add e2e test for building from private reg Add e2e test for building from private registry Mar 20, 2020
Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!
Just maybe a code duplication removal opportunity?

e2e/build_push_test.go Outdated Show resolved Hide resolved
Updates the e2e test for building from a private registry during
build-push. First build and push a base image and remove it locally then
build and push an image based on it.

Signed-off-by: Nick Adcock <nick.adcock@docker.com>
@zappy-shu zappy-shu force-pushed the login-before-build branch from cdab64c to cd2d03d Compare March 20, 2020 15:27
@zappy-shu zappy-shu merged commit 468bbd1 into master Mar 23, 2020
@zappy-shu zappy-shu deleted the login-before-build branch March 23, 2020 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants