-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove server support for TLS 1.0 and 1.1 #50
Conversation
cc @n4ss |
642b442
to
95327a3
Compare
I think that go-connections is used pretty much everywhere by docker, and some clients (ex: homebrew's This is why I added modifiers on the default config generators: 5bd7d32 That way we can set the min TLS version project-by-project / product-by-product accordingly to back-compatibility. ps: I created a PR for homebrew's formula |
For Docker for Mac (which may only support 10.11 and 1.12 now?) we can ship compose linked against any version we like. That is also what Apple seems to recommend anyway. For self install most people use homebrew, which has later versions. So I think we should fix this in compose. |
Is there any good reason to keep around TLSv1.1 as the minimum version as opposed to just going straight to TLSv1.2. I don't know of any clients that support 1.1 and not 1.2 |
Yes, happy to remove 1.1 at the same time. Amended. |
95327a3
to
0510452
Compare
This should not be needed any more and is not recommended. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
0510452
to
eed1c49
Compare
@n4ss @justincormack Possibly docker-compose and |
LGTM |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
This should not be needed any more and is not recommended.
Signed-off-by: Justin Cormack justin.cormack@docker.com