Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert "configureNpipeTransport: use winio.DialPipeContext()" #91

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

revert "configureNpipeTransport: use winio.DialPipeContext()" #91

wants to merge 2 commits into from

Conversation

thaJeztah
Copy link
Member

This reverts #70, as it's possibly causing the failures as seen on moby/moby#41084

thaJeztah added 2 commits July 26, 2021 16:26
@thaJeztah
Revert "sockets: defaultTimeout is unused on Windows (deadcode)"
9490ede 
This reverts commit fcf9eb7.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Revert "configureNpipeTransport: use winio.DialPipeContext()"
65d2484 
This reverts commit ad28c33.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Only reverting #70 isn't enough; tests still fail;

=== FAIL: github.com/docker/docker/integration/build  (0.00s)
[2021-07-26T14:49:21.575Z] failed to get info from daemon: Error response from daemon: client version 1.42 is too new. Maximum supported API version is 1.41
[2021-07-26T14:49:21.575Z] exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thaJeztah