Use uint64 for parseSize #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #19 |
Functions like RAMInBytes offen used to parse memory set to cgroup, while Linux kernel take cgroup memory value as uint64, so we need the return value of RAMInBytes also be uint64, otherwise we are not able to set memory larger than MAX(int64) and smaller than MAX(uint64). This'll somewhat break compatibility since parseSize returns 0 when input is not parseable, but I doubt people actually depend on that because we already return error, so I don't think this'll be a problem. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
hqhq
force-pushed
the
use_uint64_for_parsesize
branch
from
39486a7 to
b7f5cdf
Compare
|
@dnephin Thanks for reviewing, I'm aware this'll break backward compatibility, as I said in commit log, I's a real bugfix, the bug impacts Docker and runc and all other projects which are using go-units, and I believe the backward compatibility break is very limited and acceptable. Even that I noticed go-units is still 0.3.1, usually we don't have to guarantee backward compatibility before 1.0 right? |
|
@kolyshkin @AkihiroSuda ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions like
RAMInBytesoffen used to parse memoryset to cgroup, while Linux kernel take cgroup memory
value as uint64, so we need the return value of
RAMInBytesalso be uint64, otherwise we are not ableto set memory larger than MAX(int64) and smaller than
MAX(uint64).
This'll somewhat break compatibility since parseSize
returns 0 when input is not parseable, but I doubt
people actually depend on that because we already
return error, so I don't think this'll be a problem.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com