Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Login issue #191 #192

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Fix Login issue #191 #192

merged 1 commit into from
Nov 18, 2021

Conversation

silvin-lubecki
Copy link
Collaborator

- What I did
Fix the login which failed with Error: failed to authenticate: bad status code "400 Bad Request": malformed request: EOF.

- How I did it

ioutil.NopCloser set content-length header to 0, which is no more accepted by the backend.

- How to verify it

$ hub-tool login
Username: slubecki
Password: 
2FA required, please provide the 6 digit code: XXXXXX
Login Succeeded

- Description for the changelog
Fix login issue #191

- A picture of a cute animal (not mandatory)
image

…re accepted by the backend.

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@glours glours merged commit c9cb0ac into main Nov 18, 2021
@glours glours deleted the fix-login-issue branch November 18, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants