This repository has been archived by the owner on Jun 16, 2021. It is now read-only.
Fixes some v2 yaml parsing 🐹 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
v2-yaml-fixes
branch
2 times, most recently
from
f336219 to
2ab0c34
Compare
| return nil | ||
| } | ||
|
|
||
| func handleBuildArgs(value interface{}) (map[string]string, error) { |
There was a problem hiding this comment.
Maybe we shouldn't make these two functions specific to build arguments. We'll probably have to do something similar for logging arguments, so maybe we can move these to a utils.go?
There was a problem hiding this comment.
Hum right now logging key works fine, but I'll keep that in mind because yeah, that's a pretty generic way of handling a map 👼
|
Returning the config version is definitely a good idea. Awesome work with all of the new types. Hopefully that wasn't too tedious! Just one comment, but LGTM other than that. |
This will be needed for v2 network support. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
- Split into smaller files (with test) to make it easier to read - Add a Build type that handle some Build magic - Add an External type that handle some external magic (networks, volumes) - Add Networks/Network type that handle some Networks magic - Refactor the Ulimit types to be simpler and not user reflection Also adds a merge_fixtures_test.go and testdata folder with some existing compose file to make sure it parses it well (should serve as quick regression tests in the future too). Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Store config version in project 🐮
This is needed for
networksandvolumessupport as we are gonna need to know the version of the config file to act based on it.Some
yamlrefactoring/magic andconfigupdates 🐹Doing several things:
Buildtype that handle some Build magicExternaltype that handle some external magic (networks, volumes)Networks/Networktype that handle some Networks magicUlimittypes to be simpler and not user reflectionAlso adds a
merge_fixtures_test.goandtestdatafolder with some existing compose file to make sure it parses it well (should serve as quick regression tests in the future too)./cc @joshwget (master of the yaml 😂 😝)
Fixes #291
Needed for #277 and #288 implementations
🐸 🐸