Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not wait lock when network broken #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

9sheng
Copy link

@9sheng 9sheng commented Sep 21, 2017

I use github.com/docker/leadership with etcd store. When there is only 1 candidate, if the networks break down(i.e. use iptables) and then recover, the candidate cannot get the lock.
The reason is that if the candidate is waiting for the lock when networks recover, the wait will never return. since no other candidate exists, the lock node will NEVER be changed.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix-etcd-lock" git@github.com:9sheng/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants