boltdb/bolt is not maintained. Use bbolt instead. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2018 12:42
Signed-off-by: John Howard <jhoward@microsoft.com>
Signed-off-by: John Howard <jhoward@microsoft.com>
|
Replaces #200. Ping @thaJeztah. Added a second commit to bump golang to latest 1.8 release (although entirely not supported, but slightly less unsupported than 1.7.1....) |
lowenna
force-pushed
the
etcd-io-bbolt
branch
from
1f22601
to
c6b4d57
Compare
|
Added third commit to bump zookeeper - CI fails as those versions are no longer present. |
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
etcd-io-bbolt
branch
from
c6b4d57
to
da0a707
Compare
|
Yay, green CI :) |
thaJeztah
approved these changes
Sep 12, 2018
| "github.com/docker/libkv" | ||
| "github.com/docker/libkv/store" | ||
| bolt "go.etcd.io/bbolt" |
There was a problem hiding this comment.
nit: Was the alias needed? I think it worked without
There was a problem hiding this comment.
Ah, the package name in the new repo is bbolt, not bolt. I'm following the import recommendation at https://github.com/etcd-io/bbolt#installing
This was referenced Sep 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Part fix for moby/libnetwork#1950
github.com/boltdb/bolt is no longer being maintained. From https://github.com/boltdb/bolt:
In order to fix the libnetwork issue, I need to change consumers over to the new package, so that I can ultimately pull in this fix: etcd-io/bbolt#122.
This PR uses the import syntax recommended at https://github.com/etcd-io/bbolt#importing-bbolt
@mavenugo PTAL. cc @vieux @johnstep
@carlfischer1 - This will be one change of a few to get that libnetwork issue fixed and pulled into backport.