Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test login against registries pt.1 #23

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Test login against registries pt.1 #23

merged 4 commits into from
Nov 10, 2020

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 23, 2020

Add e2e tests against different kind of registries for our login action. Before merge we need to add the following secrets to the repo:

First PR against:

  • DockerHub
    • DOCKERHUB_USERNAME
    • DOCKERHUB_TOKEN
  • GitHub Container Registry
    • GHCR_USERNAME
    • GHCR_PAT
  • Gitlab
    • GITLAB_USERNAME
    • GITLAB_TOKEN

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

crazy-max and others added 3 commits October 23, 2020 18:09
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title Test login against registries Test login against registries pt.1 Nov 10, 2020
@crazy-max crazy-max marked this pull request as ready for review November 10, 2020 09:04
@crazy-max crazy-max merged commit 71b3c78 into docker:master Nov 10, 2020
@crazy-max crazy-max deleted the login-test branch November 10, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant