Skip to content
This repository has been archived by the owner on Sep 26, 2021. It is now read-only.

Added option to disable virtualbox vbfs mount of users home directory #1622

Merged
merged 1 commit into from
Aug 12, 2015
Merged

Added option to disable virtualbox vbfs mount of users home directory #1622

merged 1 commit into from
Aug 12, 2015

Conversation

rawkode
Copy link
Contributor

@rawkode rawkode commented Jul 31, 2015

No description provided.

@rawkode rawkode mentioned this pull request Jul 31, 2015
Closed
@ehazlett
Copy link
Contributor

ehazlett commented Aug 6, 2015

Thanks for the contribution! It's a minor nit but do you think we could rename this to something like virtualbox-no-share. I think the vbfs gets a little implementation specific.

It also needs a rebase. Thanks!

@rawkode
Copy link
Contributor Author

rawkode commented Aug 6, 2015

No problem, I'll update. Thanks

@Oliboy50
Copy link

Oliboy50 commented Aug 6, 2015

Nice feature here.
I was wondering recently that I should use another file sharing system to speed up my development processes... But ended up to give up because there was the default sharing VBFS stuff anyway.
Thanks :)

nathanleclaire
nathanleclaire reviewed Aug 6, 2015
View reviewed changes
drivers/virtualbox/virtualbox.go
@@ -300,7 +306,7 @@ func (d *Driver) Create() error {
return err
}

if shareDir != "" {
if shareDir != "" && d.NoVboxFsShare == false {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This should probably read, if shareDir != "" && !d.NoVBoxFsShare {

@nathanleclaire
Copy link
Contributor

Looks pretty good to me, needs a rebase.

@rawkode
Copy link
Contributor Author

rawkode commented Aug 10, 2015

Updated as per requests 👍

@nathanleclaire
Copy link
Contributor

LGTM

@ehazlett
Copy link
Contributor

LGTM

/cc @moxiegirl

@moxiegirl
Copy link

Thanks @rawkode LGTM to me --- needs rebase and squash as Evan noticed. How to here:

http://docs.docker.com/project/create-pr/#rebase-your-branch

@rawkode
* Added option to disable virtualbox vbfs user home directory mount
07e7604 
* Updated documentation with new option
* Updated flag name

Signed-off-by: David McKay <david@rawkode.com>
@rawkode
Copy link
Contributor Author

rawkode commented Aug 12, 2015

@moxiegirl rebased and squashed 😄

nathanleclaire added a commit that referenced this pull request Aug 12, 2015
@nathanleclaire
Merge pull request #1622 from rawkode/virtualbox-no-vbfs-share-flag
49764bb 
Added option to disable virtualbox vbfs mount of users home directory
@nathanleclaire nathanleclaire merged commit 49764bb into docker:master Aug 12, 2015
@moxiegirl
Copy link

@rawkode thank you sir. nice job there. 🌟

@legal90 legal90 mentioned this pull request Aug 21, 2015
Closed
5 tasks
@legal90 legal90 mentioned this pull request Oct 27, 2015
Merged
@ghost ghost mentioned this pull request Nov 5, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rawkode @ehazlett @Oliboy50 @nathanleclaire @moxiegirl