-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truncate runDir path name #68
truncate runDir path name #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the issue number from your commit message otherwise it would spam the issue with messages on rebase, thanks!
1b0f551
to
bd5d9f7
Compare
@crazy-max I've amended the commit message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to run docker buildx bake pre-checkin
to generate dist, see https://github.com/crazy-max/ghaction-setup-docker/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request
Commit example chore: update generated content
: https://github.com/crazy-max/ghaction-setup-docker/pull/58/commits
bd5d9f7
to
0cb459c
Compare
Thanks for the pointers! I've followed the guide but I am getting the following error when running I've tried running I have commited the new |
Thanks, did you commit before running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Fix #67 by reducing the runDir directory name from 57 characters to 29 charaters, preventing the socket path from being more than the maximum of 104 charaters on Unix based systems.