Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate runDir path name #68

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

MatthewCane
Copy link
Contributor

Fix #67 by reducing the runDir directory name from 57 characters to 29 charaters, preventing the socket path from being more than the maximum of 104 charaters on Unix based systems.

@MatthewCane MatthewCane requested a review from crazy-max as a code owner April 23, 2024 10:07
@crazy-max crazy-max changed the title Truncate runDir path name, fix #67 truncate runDir path name Apr 24, 2024
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the issue number from your commit message otherwise it would spam the issue with messages on rebase, thanks!

@MatthewCane MatthewCane force-pushed the truncate-rundir-path-name branch from 1b0f551 to bd5d9f7 Compare April 24, 2024 10:26
@MatthewCane
Copy link
Contributor Author

@crazy-max I've amended the commit message

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to run docker buildx bake pre-checkin to generate dist, see https://github.com/crazy-max/ghaction-setup-docker/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request

Commit example chore: update generated content: https://github.com/crazy-max/ghaction-setup-docker/pull/58/commits

@MatthewCane MatthewCane force-pushed the truncate-rundir-path-name branch from bd5d9f7 to 0cb459c Compare April 24, 2024 12:24
@MatthewCane
Copy link
Contributor Author

Thanks for the pointers! I've followed the guide but I am getting the following error when running docker buildx bake validate: 'ERROR: Build result differs. Please build first with "docker buildx bake build"'.

I've tried running docker buildx bake build as well as removing everything and going through the steps again but I am still getting the error.

I have commited the new dist files anyway, just so you can see what it comes out with but I will amend that commit if I can get the validate step to complete successfully.

@MatthewCane MatthewCane requested a review from crazy-max April 24, 2024 15:43
@crazy-max
Copy link
Member

Thanks for the pointers! I've followed the guide but I am getting the following error when running docker buildx bake validate: 'ERROR: Build result differs. Please build first with "docker buildx bake build"'.

Thanks, did you commit before running validate? This might be related but I will take a look.

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit b74351a into docker:master Apr 25, 2024
22 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unix socket path too long error when using action in self-hosted runner
2 participants