Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_org_member: revamp the model #73

Merged
merged 1 commit into from
Dec 12, 2024
Merged

docker_org_member: revamp the model #73

merged 1 commit into from
Dec 12, 2024

Conversation

nicks
Copy link
Contributor

@nicks nicks commented Dec 6, 2024

  • the invite API lets you send invites by username and email
  • before this PR, docker_org_member was designed to match
    the invite API
  • In practice, this made it impossible to implement
    import behavior.
  • now, we model docker_org_member closer to how
    the list org members api represents things

Signed-off-by: Nick Santos nick.santos@docker.com

@nicks nicks requested a review from a team as a code owner December 6, 2024 22:33
@nicks
Copy link
Contributor Author

nicks commented Dec 6, 2024

oops, i think a bunch of unrelated docs changes got spun up here. opened that as a separate PR - #74

@ryanhristovski
Copy link
Member

@nicks doc changes are still showing here, once removed can ✅

- the invite API lets you send invites by username and email
- before this PR, docker_org_member was designed to match
  the invite API
- In practice, this made it impossible to implement
  import behavior.
- now, we model docker_org_member closer to how
  the list org members api represents things

Signed-off-by: Nick Santos <nick.santos@docker.com>
@nicks
Copy link
Contributor Author

nicks commented Dec 11, 2024

updated!

@nicks nicks merged commit 94c7737 into main Dec 12, 2024
3 checks passed
@nicks nicks deleted the nicks/import branch December 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants