Remove EC2 Dockstore deploy #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coverbeck
approved these changes
Nov 7, 2022
svonworl
approved these changes
Nov 8, 2022
I think so, with https://github.com/dockstore/dockstore/blob/develop/docker-compose.yml in play, I'm not sure what else should be in here but what we use for Fargate (except for maybe the Kibana stuff which we may resurrect at some point) |
denis-yuen
reviewed
Nov 8, 2022
|
Seconded on merging compose_setup into -deploy |
david4096
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes code that supports the EC2 Dockstore deploy. This includes removing the docker-compose file, webservice-digest script, and the Dockerfile used to build the nginx image. There are other things untouched in this repo that aren't used for Fargate Dockstore...not sure if that should be cleaned up. Eventually, it would be nice to collapse this repo into dockstore-deploy.
Also added removing
IS_FARGATE_DEPLOYfrom Secrets Manager in the release checklist.I haven't updated the README yet, will wait for some initial feedback first.
This PR is a companion to https://github.com/dockstore/dockstore-deploy/pull/643.
Review Instructions
Verify that the Fargate Dockstore deploy is successful. Can look in dockstore-dev-info for the nightly deploy message to confirm the deploy in QA succeeded.
Issue
SEAB-4723
Please make sure that you've checked the following before submitting your pull request. Thanks!