Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce pin #206

Merged
merged 1 commit into from
Nov 16, 2022
Merged

reduce pin #206

merged 1 commit into from
Nov 16, 2022

Conversation

denis-yuen
Copy link
Member

Description
Reduce pinning for github provided github actions

Review Instructions
Just see if github actions are continuing to pass

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5000

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Nov 15, 2022
@denis-yuen denis-yuen marked this pull request as ready for review November 15, 2022 18:24
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096 and hyunnaye and removed request for a team November 15, 2022 18:24
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 68.57% // Head: 68.34% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (5120737) compared to base (4789745).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #206      +/-   ##
===========================================
- Coverage    68.57%   68.34%   -0.24%     
===========================================
  Files           49       49              
  Lines         6011     6011              
  Branches       792      792              
===========================================
- Hits          4122     4108      -14     
- Misses        1570     1575       +5     
- Partials       319      328       +9     
Flag Coverage Δ
bitbuckettests 9.89% <ø> (ø)
confidentialtooltests 53.72% <ø> (-0.07%) ⬇️
confidentialworkflowtests 28.39% <ø> (-0.09%) ⬇️
nonconfidentialtests 32.78% <ø> (-0.12%) ⬇️
singularitytests 16.70% <ø> (ø)
unittests 8.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 46.91% <0.00%> (-1.49%) ⬇️
...io/dockstore/client/cli/nested/WorkflowClient.java 72.97% <0.00%> (-1.38%) ⬇️
...in/java/io/github/collaboratory/cwl/CWLClient.java 80.28% <0.00%> (-0.18%) ⬇️
...ckstore/client/cli/nested/AbstractEntryClient.java 74.10% <0.00%> (+0.09%) ⬆️
...ain/java/io/dockstore/common/FileProvisioning.java 71.47% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen merged commit 759fa2e into develop Nov 16, 2022
@denis-yuen denis-yuen deleted the feature/reduce_ci_pin branch November 16, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants