Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display server-url #220

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Display server-url #220

merged 3 commits into from
Jan 27, 2023

Conversation

KimberleyChong
Copy link
Contributor

@KimberleyChong KimberleyChong commented Jan 26, 2023

Description
Ever changed your config file and forgot which server you were accessing? Well we have a solution for you ;) This pr adds the server-url from your config file to the existing --server-metadata command.

Example output:

$ dockstore --server-metadata
{
  "apiVersion": "2.0.0",
  "country": "CAN",
  "friendlyName": "Dockstore",
  "version": "1.13.1"
}
server-url: https://dockstore.org/api

Charles brought up a great observation that this command is using the TRS 2.0.0-beta.2 API similar to a previous ticket so I've also created a new ticket to switch to the TRS 2.0.0 API.

Review Instructions
Build changes and run the --server-metadata command, ensure the server-url printed matches ~/.dockstore/config

Issue
DOCK-2198
GitHub issue

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@KimberleyChong KimberleyChong self-assigned this Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 69.56% // Head: 69.47% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (112c04e) compared to base (b99cb40).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #220      +/-   ##
=============================================
- Coverage      69.56%   69.47%   -0.10%     
+ Complexity      1058     1044      -14     
=============================================
  Files             47       47              
  Lines           5937     5939       +2     
  Branches         776      776              
=============================================
- Hits            4130     4126       -4     
  Misses          1493     1493              
- Partials         314      320       +6     
Flag Coverage Δ
bitbuckettests 10.05% <66.66%> (+0.01%) ⬆️
confidentialtooltests 53.78% <100.00%> (-0.19%) ⬇️
confidentialworkflowtests 28.54% <66.66%> (-0.01%) ⬇️
nonconfidentialtests 33.05% <66.66%> (+0.03%) ⬆️
singularitytests 16.93% <66.66%> (+0.01%) ⬆️
unittests 8.04% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/io/dockstore/client/cli/Client.java 49.00% <100.00%> (+0.50%) ⬆️
...io/dockstore/client/cli/nested/WorkflowClient.java 74.04% <0.00%> (-0.62%) ⬇️
...ckstore/client/cli/nested/AbstractEntryClient.java 73.90% <0.00%> (-0.30%) ⬇️
...ava/io/dockstore/client/cli/nested/ToolClient.java 72.25% <0.00%> (-0.14%) ⬇️
...ockstore/client/cli/nested/BaseLanguageClient.java 58.43% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KimberleyChong KimberleyChong changed the title display server-url in --server-metadata Display server-url Jan 26, 2023
@KimberleyChong KimberleyChong marked this pull request as ready for review January 26, 2023 20:15
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@KimberleyChong KimberleyChong merged commit a11fec6 into develop Jan 27, 2023
@KimberleyChong KimberleyChong deleted the DOCK-2198/display-server-url branch January 27, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants