Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace expired docker image #240

Merged
merged 3 commits into from
May 29, 2023
Merged

replace expired docker image #240

merged 3 commits into from
May 29, 2023

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented May 26, 2023

Description
All dockstore-cli builds past a certain date are failing, regardless of branch which is weird.
Turns out, a docker image expired

Review Instructions
Non confidential builds should pass again after this ticket

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5558

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this May 26, 2023
@denis-yuen
Copy link
Member Author

denis-yuen commented May 26, 2023

INFO ['docker', 'pull', 'java:7']
Error response from daemon: manifest for java:7 not found: manifest unknown: manifest unknown
ERROR Workflow error, try again with --debug for more information:
Docker is not available for this tool, try --no-container to disable Docker, or install a user space Docker replacement like uDocker with --user-space-docker-cmd.: Command '['docker', 'pull', 'java:7']' returned non-zero exit status 1.
17:59:56.126 [main] ERROR io.dockstore.common.Utilities - problems running command: cwltool --enable-dev --non-strict --outdir /home/circleci/project/dockstore-client/datastore//launcher-c9f8b879-3d14-478f-b79c-e1f105151fa6/outputs/ --tmpdir-prefix /home/circleci/project/dockstore-client/datastore//launcher-c9f8b879-3d14-478f-b79c-e1f105151fa6/tmp/ --tmp-outdir-prefix /home/circleci/project/dockstore-client/datastore//launcher-c9f8b879-3d14-478f-b79c-e1f105151fa6/working/ /home/circleci/project/dockstore-client/target/test-classes/1st-workflow.cwl /home/circleci/project/dockstore-client/datastore/launcher-c9f8b879-3d14-478f-b79c-e1f105151fa6/workflow_params.json
org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)

;grumble:

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.29 🎉

Comparison is base (97aff48) 64.97% compared to head (b3d5a55) 69.26%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #240      +/-   ##
=============================================
+ Coverage      64.97%   69.26%   +4.29%     
- Complexity       947     1048     +101     
=============================================
  Files             47       47              
  Lines           6081     6081              
  Branches         802      802              
=============================================
+ Hits            3951     4212     +261     
+ Misses          1772     1524     -248     
+ Partials         358      345      -13     
Flag Coverage Δ
bitbuckettests 9.86% <ø> (ø)
confidentialtooltests 54.79% <ø> (-0.12%) ⬇️
confidentialworkflowtests 27.98% <ø> (-0.02%) ⬇️
nonconfidentialtests 32.26% <ø> (+8.38%) ⬆️
singularitytests 16.60% <ø> (ø)
unittests 8.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-yuen denis-yuen marked this pull request as ready for review May 26, 2023 20:12
@denis-yuen denis-yuen changed the title not sure why this happened replace expired docker image May 26, 2023
@denis-yuen denis-yuen merged commit 242b363 into develop May 29, 2023
@denis-yuen denis-yuen deleted the feature/odd_fixes branch May 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants