Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new broad artifactory location #251

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 4, 2023

Description
Has been tripping up the nightly compatibility (with the webservice) builds.
Broad artifactory has moved and gives out corrupted info with a redirect if we point at the wrong URL

Review Instructions
Nightly cron build should work
https://github.com/dockstore/dockstore-cli/actions/workflows/cron.yml

Issue
n/a

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 4, 2023
@denis-yuen denis-yuen changed the title new broad location new broad artifactory location Aug 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (ab4e6bb) 70.44% compared to head (5126fff) 70.36%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #251      +/-   ##
=============================================
- Coverage      70.44%   70.36%   -0.09%     
+ Complexity      1062     1045      -17     
=============================================
  Files             47       47              
  Lines           6067     6067              
  Branches         799      799              
=============================================
- Hits            4274     4269       -5     
  Misses          1451     1451              
- Partials         342      347       +5     
Flag Coverage Δ
bitbuckettests 9.84% <ø> (ø)
confidentialtooltests 55.62% <ø> (-0.32%) ⬇️
confidentialworkflowtests 30.50% <ø> (ø)
nonconfidentialtests 32.35% <ø> (+0.03%) ⬆️
singularitytests 16.56% <ø> (ø)
unittests 8.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye, y-ng, coverbeck and kathy-t and removed request for a team August 4, 2023 14:58
@denis-yuen denis-yuen merged commit ad4a2ea into develop Aug 4, 2023
16 of 17 checks passed
@denis-yuen denis-yuen deleted the feature/new_broad_artifactory branch August 4, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants