Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockstore version #260

Merged
merged 1 commit into from
Sep 27, 2023
Merged

update dockstore version #260

merged 1 commit into from
Sep 27, 2023

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Sep 26, 2023

Description
Pairs with dockstore/dockstore#5678
Updates bom but removes hierarchy change

Review Instructions
Should pass builds

Issue
dockstore/dockstore#5678
dockstore/dockstore#5605

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Sep 26, 2023
@denis-yuen denis-yuen changed the title update update dockstore version Sep 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (63687b9) 70.39% compared to head (f0f7b16) 70.41%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #260      +/-   ##
=============================================
+ Coverage      70.39%   70.41%   +0.01%     
+ Complexity      1076     1073       -3     
=============================================
  Files             47       47              
  Lines           6070     6070              
  Branches         799      799              
=============================================
+ Hits            4273     4274       +1     
  Misses          1466     1466              
+ Partials         331      330       -1     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.79% <ø> (-0.19%) ⬇️
confidentialworkflowtests 30.32% <ø> (-0.04%) ⬇️
nonconfidentialtests 32.40% <ø> (+0.03%) ⬆️
singularitytests 16.58% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-yuen denis-yuen requested review from a team, david4096, hyunnaye, svonworl and coverbeck and removed request for a team September 26, 2023 20:46
@denis-yuen denis-yuen marked this pull request as ready for review September 26, 2023 20:46
@denis-yuen denis-yuen merged commit b94ad45 into develop Sep 27, 2023
17 checks passed
@denis-yuen denis-yuen deleted the feature/hierarchy_fix_2 branch September 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants