Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating cwltool dependencies #291

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Conversation

david4096
Copy link
Member

Description

Updates cwltool dependencies

Review Instructions

CLI should install cwltool using updated dependencies from webservice dockstore/dockstore#5958

Issue

dockstore/dockstore#5921

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@david4096 david4096 force-pushed the feature/dock-2539/cwltool-deps branch from 6ea53fb to abcb568 Compare August 8, 2024 04:53
Annoying test failure for noInternetTest
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (89e75fe) to head (190e61e).
Report is 1 commits behind head on hotfix/1.15.1.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             hotfix/1.15.1     #291      +/-   ##
===================================================
- Coverage            70.25%   70.11%   -0.15%     
+ Complexity            1068     1057      -11     
===================================================
  Files                   47       47              
  Lines                 6069     6069              
  Branches               801      801              
===================================================
- Hits                  4264     4255       -9     
  Misses                1466     1466              
- Partials               339      348       +9     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.74% <ø> (-0.15%) ⬇️
confidentialworkflowtests 30.18% <ø> (-0.10%) ⬇️
nonconfidentialtests 32.39% <ø> (+0.01%) ⬆️
singularitytests 16.59% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david4096 david4096 marked this pull request as ready for review August 8, 2024 17:47
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval in principle, obviously need a real release for final merge but you're probably on this

@david4096
Copy link
Member Author

david4096 commented Aug 8, 2024

Approval in principle, obviously need a real release for final merge but you're probably on this

Yes, this is to prove the webservice PR is ok, then we can fix this one up and merge. Will re-request review then.

@david4096 david4096 force-pushed the feature/dock-2539/cwltool-deps branch from 2bd362e to aa74b5b Compare August 15, 2024 19:17
@david4096 david4096 force-pushed the feature/dock-2539/cwltool-deps branch from 0da52cb to 190e61e Compare August 15, 2024 20:10
Copy link

sonarcloud bot commented Aug 15, 2024

@david4096 david4096 merged commit 5b1e125 into hotfix/1.15.1 Aug 15, 2024
15 of 16 checks passed
@david4096 david4096 deleted the feature/dock-2539/cwltool-deps branch August 15, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants