Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2309/workflow entryname hosted and apps #52

Merged
merged 18 commits into from
Feb 9, 2023

Conversation

Richard-Hansen
Copy link
Contributor

@Richard-Hansen Richard-Hansen commented Nov 23, 2020

Ticket: https://ucsc-cgl.atlassian.net/browse/DOCK-633

Fixing previous issues regarding handling HOSTED tools and workflows and DOCKSTORE_YML workflows.
Added integration tests.

Changes were very small, hiding whitespace will help.

Richard Hansen added 2 commits November 23, 2020 15:35
@Richard-Hansen Richard-Hansen self-assigned this Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Base: 69.57% // Head: 69.57% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e7e6b6f) compared to base (0633024).
Patch coverage: 80.85% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #52      +/-   ##
=============================================
- Coverage      69.57%   69.57%   -0.01%     
- Complexity      1049     1065      +16     
=============================================
  Files             47       47              
  Lines           6041     6050       +9     
  Branches         792      796       +4     
=============================================
+ Hits            4203     4209       +6     
  Misses          1510     1510              
- Partials         328      331       +3     
Flag Coverage Δ
bitbuckettests 9.93% <4.25%> (+0.01%) ⬆️
confidentialtooltests 54.79% <53.19%> (+0.26%) ⬆️
confidentialworkflowtests 27.76% <34.04%> (-0.06%) ⬇️
nonconfidentialtests 32.41% <4.25%> (-0.05%) ⬇️
singularitytests 16.69% <4.25%> (+<0.01%) ⬆️
unittests 8.38% <4.25%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/io/dockstore/client/cli/ArgumentUtility.java 84.52% <ø> (ø)
...io/dockstore/client/cli/nested/WorkflowClient.java 70.93% <78.94%> (-0.39%) ⬇️
...ava/io/dockstore/client/cli/nested/ToolClient.java 72.64% <82.14%> (+0.01%) ⬆️
...in/java/io/github/collaboratory/wdl/WDLClient.java 79.20% <0.00%> (-1.00%) ⬇️
.../src/main/java/io/dockstore/client/cli/Client.java 50.00% <0.00%> (-0.25%) ⬇️
...ckstore/client/cli/nested/AbstractEntryClient.java 74.85% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2020

This pull request introduces 2 alerts and fixes 2 when merging ba43a63 into 1f9fa14 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

fixed alerts:

  • 2 for Dereferenced variable may be null

@lgtm-com
Copy link

lgtm-com bot commented Nov 24, 2020

This pull request introduces 2 alerts and fixes 2 when merging 016d17a into 1f9fa14 - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

fixed alerts:

  • 2 for Dereferenced variable may be null

@Richard-Hansen
Copy link
Contributor Author

Looks like there are some unexpected TravisCI errors, I'll remove reviewers until after fixing them.

Sorry for the email clutter.

@lgtm-com
Copy link

lgtm-com bot commented Dec 9, 2020

This pull request fixes 2 alerts when merging bdf225d into c92896b - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 11 Code Smells

No Coverage information No Coverage information
2.5% 2.5% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

5.6% 5.6% Coverage
2.5% 2.5% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2022

This pull request fixes 2 alerts when merging 33cce74 into 64911f5 - view on LGTM.com

fixed alerts:

  • 2 for Dereferenced variable may be null

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.4% 77.4% Coverage
0.0% 0.0% Duplication

@denis-yuen
Copy link
Member

FYI, this was mostly about trying out the various changes to the build, webservice (cache, rate limit behaviour)

@denis-yuen denis-yuen requested review from kathy-t and removed request for denis-yuen February 9, 2023 04:00
@denis-yuen denis-yuen merged commit 9dbf999 into develop Feb 9, 2023
@denis-yuen denis-yuen deleted the feature/2309/workflowEntrynameHostedAndApps branch February 9, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants