Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some JIRA/GitHub version syncing #495

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jun 28, 2024

Description
Does some syncing of JIRA fix version and GitHub milestone, which Unito does not do.

The syncing problem is because a fix version in JIRA is a multi-value field, whereas the milestone in GitHub is a single-value field.

See JavaDoc in MilestoneResolver.java for further details.

Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.

Issue
SEAB-5953

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@coverbeck coverbeck self-assigned this Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (3703712) to head (1b11435).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #495   +/-   ##
==========================================
  Coverage      45.70%   45.70%           
  Complexity       319      319           
==========================================
  Files             50       50           
  Lines           2700     2700           
  Branches         210      210           
==========================================
  Hits            1234     1234           
  Misses          1375     1375           
  Partials          91       91           
Flag Coverage Δ
metricsaggregator 36.70% <ø> (ø)
toolbackup 22.85% <ø> (ø)
tooltester 17.07% <ø> (ø)
topicgenerator 20.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review instructions not updated

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing review instructions, something may have gone awry with the way develop was merged into this branch.

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks fine, but should clean-up before merge

@svonworl
Copy link

Was here, but the diffs look busted, there's lots of changes in there that probably don't relate to yours. Will take another look when it's fixed.

@coverbeck
Copy link
Contributor Author

I had rebased off an older pull of develop. I updated develop locally and rebased again. Diff should be good now.

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing review instructions

Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@coverbeck coverbeck merged commit 0381ffd into develop Sep 6, 2024
10 of 11 checks passed
@coverbeck coverbeck deleted the feature/seab-6348/milestone branch September 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants