Feature/figleaf filter #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #497 +/- ##
=============================================
+ Coverage 45.13% 45.40% +0.27%
- Complexity 305 315 +10
=============================================
Files 47 50 +3
Lines 2663 2700 +37
Branches 205 209 +4
=============================================
+ Hits 1202 1226 +24
- Misses 1368 1381 +13
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denis-yuen
requested review from
a team,
coverbeck,
david4096,
hyunnaye and
kathy-t
and removed request for
a team
coverbeck
approved these changes
Aug 9, 2024
| @@ -59,6 +62,7 @@ public class TopicGeneratorClient { | |||
| private static final int MAX_CONTEXT_LENGTH = 16385; | |||
| private static final EncodingRegistry REGISTRY = Encodings.newDefaultEncodingRegistry(); | |||
| private static final Encoding ENCODING = REGISTRY.getEncodingForModel(AI_MODEL); | |||
| private final List<StringFilter> stringFilters = Lists.newArrayList(new ChuckNorrisFilter("en"), new ChuckNorrisFilter("fr-CA-u-sd-caqc")); | |||
There was a problem hiding this comment.
LOL, I was wondering how you were going to implement this without committing a bunch of foul language to our repo. :)
kathy-t
approved these changes
Aug 12, 2024
svonworl
reviewed
Aug 12, 2024
topicgenerator/src/main/java/io/dockstore/topicgenerator/helper/StringFilter.java
Outdated
Show resolved
Hide resolved
topicgenerator/src/main/java/io/dockstore/topicgenerator/helper/StringFilter.java
Outdated
Show resolved
Hide resolved
|
svonworl
approved these changes
Aug 13, 2024
david4096
approved these changes
Aug 13, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A simple filter for topic sentences, can take a look in the log to see if workflows are skipped.
A pretty naive implementation that only checks full words
I largely agree with https://blog.codinghorror.com/obscenity-filters-bad-idea-or-incredibly-intercoursing-bad-idea/ but I kinda feel that since "we're" generating these we need to do some minimal due diligence on the results and have something to refer to.
Review Instructions
Could try a bunch of different languages and tests. Or could intentionally create something offensive and try to upload it using the uploader
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6538
Security
None.
mvn clean installin the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)