Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5445: Tint notebook stream error output #1784

Merged
merged 1 commit into from
May 19, 2023

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented May 19, 2023

Description
This PR changes the background color of the error ("stderr") stream output in the notebook preview to a pleasant light-orangeish red, so that it can be differentiated from the normal ("stdout") stream output.

image

Review Instructions
Register a notebook on qa that has stderr stream output (or use the "running" notebook if it is already registered), view its Preview tab, and confirm that the background of the stderr output is reddish.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5445

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.02 🎉

Comparison is base (dbf2067) 40.89% compared to head (3c07345) 40.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1784      +/-   ##
===========================================
+ Coverage    40.89%   40.91%   +0.02%     
===========================================
  Files          359      359              
  Lines        11071    11075       +4     
  Branches      2826     2827       +1     
===========================================
+ Hits          4527     4531       +4     
- Misses        4277     4278       +1     
+ Partials      2267     2266       -1     
Impacted Files Coverage Δ
...c/app/notebook/notebook-stream-output.component.ts 50.00% <33.33%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@svonworl svonworl merged commit 5d44e63 into develop May 19, 2023
@svonworl svonworl deleted the feature/seab-5445/style-notebook-error-output branch May 19, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants