SEAB-5820: Mastodon feed widget #1837

denis-yuen · 2023-08-30T20:19:22Z

Description
This PR adds a the Mastodon Dockstore feed where the old twitter feed used to be.

Homepage:

Dashboard

Review Instructions
On qa, verify that the widget loads properly on the homepage and dashboard. Also, the new tests should pass.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5820

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

denis-yuen · 2023-08-31T21:25:37Z

Loads like an 8th of the time, more likely to succeed on initial load, probably an async loading thing.

codecov · 2023-10-03T17:27:37Z

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (662ffca) 40.70% compared to head (c45b6dd) 40.41%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1837      +/-   ##
===========================================
- Coverage    40.70%   40.41%   -0.30%     
===========================================
  Files          364      364              
  Lines        11252    11261       +9     
  Branches      2866     2888      +22     
===========================================
- Hits          4580     4551      -29     
- Misses        4376     4411      +35     
- Partials      2296     2299       +3

Files	Coverage Δ
src/app/home-page/dashboard/dashboard.component.ts	`52.00% <ø> (-4.67%)`	⬇️
...rc/app/home-page/home-logged-out/home.component.ts	`66.66% <0.00%> (-1.76%)`	⬇️
src/app/shared/mastodon/mastodon.service.ts	`4.34% <4.34%> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denis-yuen

Small comment, looks good in terms of screenshot.
Thanks for fixing this up!
(and thanks Charles for deciphering what happened)

denis-yuen · 2023-10-03T18:33:47Z

src/app/footer/footer.component.html

+                class="footer-link"
+                fxLayoutGap="0.5rem"
+              >
+                <img class="site-icons-tab" src="../../assets/images/dockstore/mastodon.svg" alt="small Twitter logo" /><small


alt text needs update

alt text needs update

Comment still applicable.

coverbeck

If I

Go to home page, Mastodon feed displays
Click on About
Click to go back to home; Mastodon feed is not there.

I think this is best solved by creating an Angular component; see my inline comment.

The major downside is we risk getting out of date with the original source for this, but I think it's worth it.

src/app/shared/twitter.service.ts

hyunnaye · 2023-10-10T18:17:43Z

src/app/shared/mastodon/mastodon.component.ts

+  postDate: string;
+  postContent: string;
+  spoilerText: string;
+  mediaContent: any[];


had to use any[] because we are getting these data from the mastodon api

hyunnaye · 2023-10-10T18:17:53Z

src/app/shared/mastodon/mastodon.component.ts

+  spoilerText: string;
+  mediaContent: any[];
+  previewLink: string;
+  poll: any[];


hyunnaye · 2023-10-10T18:18:26Z

@denis-yuen tagging for rereview

coverbeck

First, thanks for doing all this work! You went beyond what I was expecting, which just a thin wrapper around the existing Mastodon file, as a component.

Two thoughts beyond the more specific comments I left:

It would be good if there were a source code comment linking to the code you adopted your code from, in case it gets updated and we need to port it over.
I feel like the UI needs a box and/or title around it. It's not obvious to me, that it's a Mastodon feed, unless you happen to notice the "See more posts at Mastodon" link at the bottom of the component.

coverbeck · 2023-10-10T22:01:37Z

src/app/footer/footer.component.html

+                class="footer-link"
+                fxLayoutGap="0.5rem"
+              >
+                <img class="site-icons-tab" src="../../assets/images/dockstore/mastodon.svg" alt="small Twitter logo" /><small


alt text needs update

Comment still applicable.

src/app/home-page/dashboard/dashboard.component.html

src/app/home-page/home-logged-out/home.component.html

src/app/shared/mastodon/mastodon.component.ts

src/app/shared/mastodon.service.ts

hyunnaye · 2023-10-11T16:13:13Z

First, thanks for doing all this work! You went beyond what I was expecting, which just a thin wrapper around the existing Mastodon file, as a component.

Two thoughts beyond the more specific comments I left:

It would be good if there were a source code comment linking to the code you adopted your code from, in case it gets updated and we need to port it over.

I feel like the UI needs a box and/or title around it. It's not obvious to me, that it's a Mastodon feed, unless you happen to notice the "See more posts at Mastodon" link at the bottom of the component.

updated the UI by wrapping it with a mat-card. New screenshots posted.

denis-yuen

Updates look good, cannot technically approve, but otherwise approved

kathy-t

Looks good! My main question is whether we should show more than 2 posts in the mastodon timeline. Maybe 5 so the user can scroll?

src/app/shared/mastodon/mastodon.component.html

src/app/home-page/home-logged-out/home.component.html

src/app/shared/mastodon/mastodon.component.html

src/app/shared/mastodon/mastodon.component.ts

sonarcloud · 2023-10-12T17:07:10Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

14.2% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

kathy-t · 2023-10-13T13:00:35Z

src/app/shared/mastodon/mastodon.component.html

+      </div>
+      <mat-divider></mat-divider>
+      <div class="mt-footer">
+        <a [href]="mastodonDockstoreLink" class="btn" target="_blank" rel="nofollow noopener noreferrer">


btn class doesn't exist

denis-yuen added 2 commits August 30, 2023 16:18

initial hack

242c0a2

need help, partially functional

01889cb

hyunnaye added 4 commits September 26, 2023 15:19

Merge branch 'develop' into feature/mastodon_stub

004bb8c

Merge branch 'develop' into feature/mastodon_stub

0dfc837

load fix

474dcab

add tests

34a876a

hyunnaye self-assigned this Oct 3, 2023

codacy

d39f9e9

hyunnaye changed the title ~~initial hack~~ SEAB-5820: Mastodon feed widget Oct 3, 2023

hyunnaye added 3 commits October 3, 2023 13:05

fix test

ce16b2f

fix test

b2556d1

fix test

b30566a

hyunnaye marked this pull request as ready for review October 3, 2023 17:55

hyunnaye requested review from coverbeck, svonworl and kathy-t and removed request for coverbeck and svonworl October 3, 2023 18:11

denis-yuen commented Oct 3, 2023

View reviewed changes

coverbeck reviewed Oct 3, 2023

View reviewed changes

src/app/shared/twitter.service.ts Outdated Show resolved Hide resolved

src/app/shared/twitter.service.ts Outdated Show resolved Hide resolved

src/app/shared/twitter.service.ts Outdated Show resolved Hide resolved

hyunnaye added 2 commits October 10, 2023 11:39

new component

033d3b8

oops forgot to add files

ccf78fb

hyunnaye reviewed Oct 10, 2023

View reviewed changes

hyunnaye requested a review from coverbeck October 10, 2023 18:18

hyunnaye added 2 commits October 10, 2023 14:33

oops

9c0a6ec

codacy

15e7969

denis-yuen requested review from coverbeck, kathy-t and svonworl and removed request for kathy-t, svonworl and coverbeck October 10, 2023 18:54

sonarcloud

c544ebc

coverbeck approved these changes Oct 10, 2023

View reviewed changes

pr review

8c84e5a

denis-yuen commented Oct 11, 2023

View reviewed changes

denis-yuen requested a review from david4096 October 11, 2023 17:56

kathy-t reviewed Oct 12, 2023

View reviewed changes

review;

c45b6dd

hyunnaye requested a review from kathy-t October 12, 2023 17:05

kathy-t approved these changes Oct 13, 2023

View reviewed changes

svonworl approved these changes Oct 14, 2023

View reviewed changes

hyunnaye merged commit 31921a3 into develop Oct 16, 2023
17 of 20 checks passed

hyunnaye deleted the feature/mastodon_stub branch October 16, 2023 14:58

hyunnaye mentioned this pull request Oct 23, 2023

SEAB-5982: fix news box on homepage #1856

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SEAB-5820: Mastodon feed widget #1837

SEAB-5820: Mastodon feed widget #1837

denis-yuen commented Aug 30, 2023 •

edited by hyunnaye

Loading

denis-yuen commented Aug 31, 2023

codecov bot commented Oct 3, 2023 •

edited

Loading

denis-yuen left a comment •

edited

Loading

denis-yuen Oct 3, 2023

coverbeck Oct 10, 2023

coverbeck left a comment

hyunnaye Oct 10, 2023

hyunnaye Oct 10, 2023

hyunnaye commented Oct 10, 2023

coverbeck left a comment

coverbeck Oct 10, 2023

hyunnaye commented Oct 11, 2023 •

edited

Loading

denis-yuen left a comment

kathy-t left a comment

sonarcloud bot commented Oct 12, 2023

kathy-t Oct 13, 2023

SEAB-5820: Mastodon feed widget #1837

SEAB-5820: Mastodon feed widget #1837

Conversation

denis-yuen commented Aug 30, 2023 • edited by hyunnaye Loading

denis-yuen commented Aug 31, 2023

codecov bot commented Oct 3, 2023 • edited Loading

Codecov Report

denis-yuen left a comment • edited Loading

Choose a reason for hiding this comment

denis-yuen Oct 3, 2023

Choose a reason for hiding this comment

coverbeck Oct 10, 2023

Choose a reason for hiding this comment

coverbeck left a comment

Choose a reason for hiding this comment

hyunnaye Oct 10, 2023

Choose a reason for hiding this comment

hyunnaye Oct 10, 2023

Choose a reason for hiding this comment

hyunnaye commented Oct 10, 2023

coverbeck left a comment

Choose a reason for hiding this comment

coverbeck Oct 10, 2023

Choose a reason for hiding this comment

hyunnaye commented Oct 11, 2023 • edited Loading

denis-yuen left a comment

Choose a reason for hiding this comment

kathy-t left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 12, 2023

kathy-t Oct 13, 2023

Choose a reason for hiding this comment

denis-yuen commented Aug 30, 2023 •

edited by hyunnaye

Loading

codecov bot commented Oct 3, 2023 •

edited

Loading

denis-yuen left a comment •

edited

Loading

hyunnaye commented Oct 11, 2023 •

edited

Loading