DOCK-2442: Handle null version in Event #1854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dockstore/dockstore#5697, in the webservice, we added a Hibernate
NotFound
annotation to make danglingEvent
versions gracefully resolve to null. This PR modifies the UI to gracefully handle said nulls by substituting some generic text where the detailed description of the version would have gone.We don't know what kind of reference the null represented, so the most future-proof generic text would be "a version". However, all of the
Events
with existing versions point to tags, so for now, it's probably relatively safe, and definitely less generic, to instead say "a tag". This PR implements the latter.Review Instructions
Find a user with a recent ADD_VERSION_TO_ENTRY event and view their profile. In the database
event
table, set theversionid
of the corresponding row to 0. Reload the profile, and confirm that the event now contains the generic text description of the version.Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2442
dockstore/dockstore#5623
Security
No concerns.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities