Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-3091: update ini to latest 4.1.1 #1873

Merged
merged 2 commits into from
Nov 17, 2023
Merged

SEAB-3091: update ini to latest 4.1.1 #1873

merged 2 commits into from
Nov 17, 2023

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Nov 16, 2023

Description
This PR updates the ini package to the latest available version: 4.1.1

Review Instructions
QA should function properly.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-3091

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Nov 16, 2023
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fecf78) 40.39% compared to head (2a52784) 40.39%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1873   +/-   ##
========================================
  Coverage    40.39%   40.39%           
========================================
  Files          367      367           
  Lines        11418    11418           
  Branches      2928     2928           
========================================
  Hits          4612     4612           
  Misses        4484     4484           
  Partials      2322     2322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyunnaye hyunnaye merged commit 2fe30b4 into develop Nov 17, 2023
20 checks passed
@hyunnaye hyunnaye deleted the feature/SEAB-3091 branch November 17, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants