Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6188: Enable notebook versions to be hidden #1916

Merged

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Jan 25, 2024

Description
Prior to this PR, in the "Edit Notebook Version" dialog, the Git Reference and Notebook Path were displayed as form inputs, and the form validation was failing, because it was applying the regexp that it uses to check workflow paths, which didn't work on notebook paths ending with .ipynb. Because the validation failed, the "Save Changes" button was disabled, thus preventing the only editable setting ("Hidden") from being submitted.

This PR displays a notebook's Git Reference and Notebook Path in divs, rather than form inputs, thus bypassing the validation, which is unnecessary because they're read only. Thus, it enables the "Save Changes" button, allowing the user to hide a notebook.

Review Instructions
On qa, select a version of one of your notebooks, and use the Actions menu to edit it and hide it. Confirm it's hidden. Then, unhide it. Next, repeat the process on one of your workflow versions, to confirm that we didn't break anything.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6188

Security
No concerns.

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@svonworl svonworl self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5596a5) 40.45% compared to head (b807169) 40.45%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.12.0    #1916   +/-   ##
===============================================
  Coverage           40.45%   40.45%           
===============================================
  Files                 369      369           
  Lines               11486    11486           
  Branches             2942     2942           
===============================================
  Hits                 4647     4647           
  Misses               4503     4503           
  Partials             2336     2336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have the correct target branch? Fix version is 1.15.

@svonworl svonworl changed the base branch from develop to release/2.12.0 January 25, 2024 21:37
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@svonworl svonworl merged commit 6a55fb2 into release/2.12.0 Jan 26, 2024
19 checks passed
@svonworl svonworl deleted the feature/seab-6188/allow-notebook-versions-to-be-hidden branch January 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants