-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEAB-6188: Enable notebook versions to be hidden #1916
SEAB-6188: Enable notebook versions to be hidden #1916
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.0 #1916 +/- ##
===============================================
Coverage 40.45% 40.45%
===============================================
Files 369 369
Lines 11486 11486
Branches 2942 2942
===============================================
Hits 4647 4647
Misses 4503 4503
Partials 2336 2336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have the correct target branch? Fix version is 1.15.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Prior to this PR, in the "Edit Notebook Version" dialog, the Git Reference and Notebook Path were displayed as form inputs, and the form validation was failing, because it was applying the regexp that it uses to check workflow paths, which didn't work on notebook paths ending with
.ipynb
. Because the validation failed, the "Save Changes" button was disabled, thus preventing the only editable setting ("Hidden") from being submitted.This PR displays a notebook's Git Reference and Notebook Path in
div
s, rather thanform
inputs, thus bypassing the validation, which is unnecessary because they're read only. Thus, it enables the "Save Changes" button, allowing the user to hide a notebook.Review Instructions
On qa, select a version of one of your notebooks, and use the Actions menu to edit it and hide it. Confirm it's hidden. Then, unhide it. Next, repeat the process on one of your workflow versions, to confirm that we didn't break anything.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6188
Security
No concerns.
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities