-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap position of Metrics and Tool tabs #1926
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.0 #1926 +/- ##
===============================================
Coverage 40.44% 40.44%
===============================================
Files 369 369
Lines 11489 11489
Branches 2944 2944
===============================================
Hits 4647 4647
Misses 4506 4506
Partials 2336 2336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the proximity to the release, I support swapping the button positions, as it is relatively safe.
However, in a hotfix, it would be easy to make the buttons less wide, so they all fit and are visible simultaneously, see this styling that I added to the accordion tab bar to make the "Archived" button fit:
:host ::ng-deep .mat-tab-label { |
This styling makes the button width adapt, so they fill what's available, but also can shrink if necessary.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
Gives a little more prominence to metrics, moving the tools tab out of the initial scrolling view, until we come up with a better solution.
Cypress test changes are annoying and a little hard-coded, but I'm going to limit the scope of this change for the release.
Review Instructions
Navigate to a workflow and version with metrics and ensure the metrics tab visible. Something like this:
Issue
SEAB-6206
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities