Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap position of Metrics and Tool tabs #1926

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jan 31, 2024

Description
Gives a little more prominence to metrics, moving the tools tab out of the initial scrolling view, until we come up with a better solution.

Cypress test changes are annoying and a little hard-coded, but I'm going to limit the scope of this change for the release.

Review Instructions
Navigate to a workflow and version with metrics and ensure the metrics tab visible. Something like this:

Screen Shot 2024-01-31 at 11 21 12 AM

Issue
SEAB-6206

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@coverbeck coverbeck self-assigned this Jan 31, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8197bf) 40.44% compared to head (a994721) 40.44%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.12.0    #1926   +/-   ##
===============================================
  Coverage           40.44%   40.44%           
===============================================
  Files                 369      369           
  Lines               11489    11489           
  Branches             2944     2944           
===============================================
  Hits                 4647     4647           
  Misses               4506     4506           
  Partials             2336     2336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@svonworl svonworl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the proximity to the release, I support swapping the button positions, as it is relatively safe.

However, in a hotfix, it would be easy to make the buttons less wide, so they all fit and are visible simultaneously, see this styling that I added to the accordion tab bar to make the "Archived" button fit:

:host ::ng-deep .mat-tab-label {

This styling makes the button width adapt, so they fill what's available, but also can shrink if necessary.

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coverbeck coverbeck merged commit b10b581 into release/2.12.0 Feb 1, 2024
18 of 19 checks passed
@coverbeck coverbeck deleted the feature/seab-6206/metrics branch February 1, 2024 19:22
coverbeck added a commit that referenced this pull request Feb 1, 2024
@coverbeck coverbeck mentioned this pull request Feb 1, 2024
11 tasks
coverbeck added a commit that referenced this pull request Feb 2, 2024
Style workflow versions so no scrolling necessary

As part of that, revert "Swap position of Metrics and Tool tabs (#1926)"

SEAB-6231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants