Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6200: hide blank metrics rows #1927

Merged
merged 6 commits into from
Feb 1, 2024
Merged

SEAB-6200: hide blank metrics rows #1927

merged 6 commits into from
Feb 1, 2024

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Jan 31, 2024

Description
This PR only adds rows in the Execution Metrics section if there are data present.

Before Fix:
Screenshot from 2024-01-31 14-42-59

After Fix:
Screenshot from 2024-01-31 14-42-13

Review Instructions
Go to https://staging.dockstore.org/workflows/github.com/gatk-workflows/seq-format-conversion/BAM-to-Unmapped-BAM:3.0.0?tab=metrics and verify that the empty CPU, Memory, Cost rows are not shown.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6200

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye marked this pull request as ready for review January 31, 2024 19:57
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b10b581) 40.44% compared to head (b10b581) 40.44%.

❗ Current head b10b581 differs from pull request most recent head 72dc195. Consider uploading reports for the commit 72dc195 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.12.0    #1927   +/-   ##
===============================================
  Coverage           40.44%   40.44%           
===============================================
  Files                 369      369           
  Lines               11489    11489           
  Branches             2944     2944           
===============================================
  Hits                 4647     4647           
  Misses               4506     4506           
  Partials             2336     2336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 1, 2024

@hyunnaye hyunnaye merged commit 959b372 into release/2.12.0 Feb 1, 2024
16 checks passed
@hyunnaye hyunnaye deleted the SEAB-6200 branch February 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants