-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SEAB-6200: hide blank metrics rows #1927
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.0 #1927 +/- ##
===============================================
Coverage 40.44% 40.44%
===============================================
Files 369 369
Lines 11489 11489
Branches 2944 2944
===============================================
Hits 4647 4647
Misses 4506 4506
Partials 2336 2336 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR only adds rows in the Execution Metrics section if there are data present.
Before Fix:
After Fix:
Review Instructions
Go to https://staging.dockstore.org/workflows/github.com/gatk-workflows/seq-format-conversion/BAM-to-Unmapped-BAM:3.0.0?tab=metrics and verify that the empty CPU, Memory, Cost rows are not shown.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6200
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities