Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add successful passing rate #1929

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jan 31, 2024

Description
Add a passing rate to metrics' UI.

Only passed and failed executions are used in the calculation (aborted are skipped).

Review Instructions

  1. Navigate to a workflow with execution metrics
  2. Go to metrics tab
  3. See percentage of passing next to total passed.
Screen Shot 2024-01-31 at 12 44 07 PM

Issue
SEAB-6201

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@coverbeck coverbeck self-assigned this Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6a55fb2) 40.45% compared to head (4de6dff) 40.44%.

Files Patch % Lines
...pp/workflow/executions/executions-tab.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/2.12.0    #1929      +/-   ##
==================================================
- Coverage           40.45%   40.44%   -0.02%     
==================================================
  Files                 369      369              
  Lines               11486    11489       +3     
  Branches             2942     2944       +2     
==================================================
  Hits                 4647     4647              
- Misses               4503     4506       +3     
  Partials             2336     2336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coverbeck coverbeck merged commit d825b7f into release/2.12.0 Feb 1, 2024
17 of 18 checks passed
@coverbeck coverbeck deleted the feature/seab-6201/passing branch February 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants