Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5992: Remove Twitter from smoke tests #1947

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

ll5zh
Copy link
Contributor

@ll5zh ll5zh commented Mar 19, 2024

Description
Previously, due to conflicting contents in staging/prod (i.e. Mastodon widget) versus qa (i.e. Twitter widget), smoke tests had to include Twitter in order to pass (#1861). Now that 1.15 has been deployed, we can remove the Twitter checks.

Review Instructions
All additions of Twitter from #1861 should be removed, and smoke tests should succeed.

Issue
SEAB-5992

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@ll5zh ll5zh self-assigned this Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.33%. Comparing base (1724c09) to head (0785ade).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1947   +/-   ##
========================================
  Coverage    40.33%   40.33%           
========================================
  Files          400      400           
  Lines        11945    11945           
  Branches      2894     2894           
========================================
  Hits          4818     4818           
  Misses        4839     4839           
  Partials      2288     2288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ll5zh ll5zh merged commit 9c9cec2 into develop Mar 19, 2024
20 checks passed
@ll5zh ll5zh deleted the feature/seab-5992 branch March 19, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants