Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCK-2335: Suppress CommonJS module warnings during build #1999

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Aug 6, 2024

Description
This PR suppresses the module warnings shown on build. Example is below.

Warning: /home/nhyun/Documents/dockstore-ui2/src/app/gravatar/gravatar.service.ts depends on 'ts-md5/dist/md5'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Warning: /home/nhyun/Documents/dockstore-ui2/src/app/search/query-builder.service.ts depends on 'bodybuilder'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Review Instructions
Build the UI and you shouldn't see these warnings on the bottom.

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2335

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@hyunnaye hyunnaye self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.41%. Comparing base (7c7ce9b) to head (3c54055).

Files Patch % Lines
src/app/gravatar/gravatar.service.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1999      +/-   ##
===========================================
- Coverage    41.67%   41.41%   -0.27%     
===========================================
  Files          393      393              
  Lines        12307    12307              
  Branches      2955     2955              
===========================================
- Hits          5129     5097      -32     
- Misses        4854     4888      +34     
+ Partials      2324     2322       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

angular.json Outdated Show resolved Hide resolved
@hyunnaye hyunnaye requested a review from coverbeck August 7, 2024 18:18
Copy link

sonarcloud bot commented Aug 7, 2024

@hyunnaye hyunnaye merged commit e6b5784 into develop Aug 8, 2024
17 of 19 checks passed
@hyunnaye hyunnaye deleted the feature/DOCK-2335 branch August 8, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants