Display engine version for Nextflow workflows #2001
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2001 +/- ##
===========================================
+ Coverage 41.67% 41.69% +0.01%
===========================================
Files 393 393
Lines 12307 12312 +5
Branches 2955 2957 +2
===========================================
+ Hits 5129 5133 +4
Misses 4854 4854
- Partials 2324 2325 +1 ☔ View full report in Codecov by Sentry. |
| </th> | ||
| <td mat-cell *matCellDef="let version"> | ||
| <div *ngFor="let engineVersion of version.versionMetadata?.engineVersions"> | ||
| <div class="no-wrap">{{ engineVersion }}</div> |
There was a problem hiding this comment.
Made this no-wrap otherwise it wraps the nextflow engine version in an unfriendly way like below
When there are multiple engine versions, they are displayed one per line
There was a problem hiding this comment.
To avoid the repetition and because we're used to seeing the most significant part of a phrase on the left of text (in left-to-right languages), I wonder if we should strip Nextflow for the version column values, e.g., just show !>=22.10.1 instead of Nextflow !>=22.10.1. It would also make the table a little less crowded.
I think it still makes sense to have the full string, with the Nextflow word on the facets page, as there are all types of workflows on the search page, whereas for this table the column is only visible on a Nextflow workflow.
There was a problem hiding this comment.
Seems intentional that we're storing the engine name based on this comment
Proposing we leave it as is for now and create a new ticket if it becomes an issue since it'll require a webservice change
There was a problem hiding this comment.
Lol, citing my own comment against my argument. :)
I'd still argue that it's redundant on this page for Nextflow. My suggestion, which wasn't clear, would be to have a pipe here, not to change it on the backend -- I think it still makes sense to have Nextflow !>=22.10.1 on the facets page for differentiation when we add other engines for other languages. But here it's already a Nextflow workflow, and there are no other engines for Nextflow other than Nextflow itself, so it's not really adding anything and slightly getting in the way of viewing the significant info.
| </th> | ||
| <td mat-cell *matCellDef="let version"> | ||
| <div *ngFor="let engineVersion of version.versionMetadata?.engineVersions"> | ||
| <div class="no-wrap">{{ engineVersion }}</div> |
There was a problem hiding this comment.
To avoid the repetition and because we're used to seeing the most significant part of a phrase on the left of text (in left-to-right languages), I wonder if we should strip Nextflow for the version column values, e.g., just show !>=22.10.1 instead of Nextflow !>=22.10.1. It would also make the table a little less crowded.
I think it still makes sense to have the full string, with the Nextflow word on the facets page, as there are all types of workflows on the search page, whereas for this table the column is only visible on a Nextflow workflow.
| </th> | ||
| <td mat-cell *matCellDef="let version"> | ||
| <div *ngFor="let engineVersion of version.versionMetadata?.engineVersions"> | ||
| <div class="no-wrap">{{ engineVersion }}</div> |
There was a problem hiding this comment.
Lol, citing my own comment against my argument. :)
I'd still argue that it's redundant on this page for Nextflow. My suggestion, which wasn't clear, would be to have a pipe here, not to change it on the backend -- I think it still makes sense to have Nextflow !>=22.10.1 on the facets page for differentiation when we add other engines for other languages. But here it's already a Nextflow workflow, and there are no other engines for Nextflow other than Nextflow itself, so it's not really adding anything and slightly getting in the way of viewing the significant info.
|
Updated so that 'Nextflow' is removed from the engine version value for the Versions tab.
|
|
Description
This PR displays the Engine Versions column instead of Language Versions for Nextflow workflows.
Review Instructions
On QA, navigate to https://qa.dockstore.org/workflows/github.com/nf-core/rnaseq:dev?tab=versions and verify that there's an Engine Versions column and no Language Versions column for Nextflow workflows. Go to a non-Nextflow workflow, click the Versions tab and verify that it has a Language Versions column.
Issue
dockstore/dockstore#5918
https://ucsc-cgl.atlassian.net/browse/DOCK-2536
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run buildmarkdown-wrappercomponent, which does extra sanitizationnpm auditand ensure you are not introducing new vulnerabilities