Recursively put files sometimes #10
Conversation
|
FYI, as discussed, this could use testing. |
* Run localstack * Add s3cmd config file * Test enum * Install s3cmd * Add test * Install s3cmd with pip * Change s3cmd client location * Wait for localstack to start
garyluu
force-pushed
the
feature/directory
branch
from
672dc25
to
266a37d
Compare
garyluu
force-pushed
the
feature/directory
branch
from
32b9771
to
f1e5722
Compare
.travis.yml
Outdated
| jdk: | ||
| - oraclejdk8 | ||
| script: | ||
| - mvn clean install | ||
| before_install: | ||
| - pip install --upgrade pip | ||
| - pip install --user s3cmd |
There was a problem hiding this comment.
lets get versions on these so they do not break unexpectedly
| private void setConfiguration() throws Exception { | ||
| HashMap hm = new HashMap(); | ||
| hm.put("client", "/home/travis/.local/bin/s3cmd"); | ||
| // hm.put("client", "/usr/local/bin/s3cmd"); |
There was a problem hiding this comment.
Does this have to be manually uncommented to run locally?
If yes, just use https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#exists(java.nio.file.Path,%20java.nio.file.LinkOption...)
If no (i.e. this is superfluous, just delete it)
There was a problem hiding this comment.
It depends on where s3cmd is installed. I happen to have mine installed in /usr/local/bin/s3cmd. Travis by default installs it in /home/travis/.local/bin/s3cmd instead. If the local user doesn't even have s3cmd installed, the tests would fail also.
There was a problem hiding this comment.
Yeah, I would just check the two locations using Files.exists and fail otherwise indicating just that
Allows uploading directories for issue #9
Only allowed if the destination ends with a slash. S3cmd would complain about uploading otherwise.