Remove T4 support #136
Merged
Remove T4 support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's what we agreed 👍 thanks |
voieducode
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for T4, which is currently causing (compatibility) friction because it's functionality is difficult to support without considerable work, knowledge and experimentation to make it work across different .NET versions and IDEs (and where it would work only in Visual Studio anyhow and not, for example, in VS Code).
This functionality can always be revived later, but my guess is that the source generator approach will prove to be more popular.
@voieducode IIRC, we agreed to this otherwise let me know if I might have misunderstood or overstepped here.