Refactor pattern matching to be static & stand alone #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors pattern matching from the virtual
Match
/SingleMatch
dispatches into a stand-alone static method with a consolidated implementation. This moves away from an object-oriented approach. The rationale for the new approach is that all the patterns are essentially a closed set of discriminated unions. ThePattern
and subclasses are internal implementation details. They are not designed for extensibility so the open-close principal doesn't come into play here. Having a consolidated implementation that pattern-matches through a switch table simplifies things greatly (including for understanding). For example, all branch patterns now just boil down to this:A less obvious motivation is that this simplification will potentially also help with static source code generation being explored in #77. While this can't be proven, the PR hopefully has merits on its own.