Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP returns blank #1

Open
bitwit opened this issue Nov 11, 2012 · 2 comments
Open

PHP returns blank #1

bitwit opened this issue Nov 11, 2012 · 2 comments

Comments

@bitwit
Copy link

bitwit commented Nov 11, 2012

Last night I played around with the PHP plugin quite a bit and it wasn't working for me. So I spent some time getting to really know it, logging the steps and determined that the

"php.on('exit', function() {"...

was always occurring before

"php.stdout.on('data', function(data) {"

so my returned result was always blank.

I hot-fixed the plugin locally by instead setting the opts.content and calling "next()" inside of on.('data') instead on.('exit')

Not sure if this is a problem local to my computer or PHP. I believe my ruby plugin was doing the same thing, I didn't go back and test this on the rb plugin yet though. Either way, it probably exposes that the plugin isn't 100% foolproof so I wanted to do my due diligence and inform you.

Cheers.

@balupton
Copy link
Member

This could actually be a problem in node itself, which is going to be fixed in 0.10:
https://dl.dropbox.com/u/3685/presentations/streams2/streams2-jsconfau.pdf

How urgent is this?

@bitwit
Copy link
Author

bitwit commented Nov 17, 2012

Not that important. I personally have what I need but I wanted to be
diligent and report it to you.

Kyle

On 2012-11-16, at 9:05 PM, Benjamin Arthur Lupton notifications@github.com
wrote:

This could actually be a problem in node itself, which is going to be fixed
in 0.10:
https://dl.dropbox.com/u/3685/presentations/streams2/streams2-jsconfau.pdf

How urgent is this?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/1#issuecomment-10469350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants